lobo/isync
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

error-check committing of sync state

Browse Source 
a failure here is rather unlikely, but let's be pedantic.
a failure is not fatal (we'll just enter the journal replay path next
time), so only print warnings.

found by coverity.
This commit is contained in:
Oswald Buddenhagen 2014-04-12 18:31:18 +02:00
parent aa0118d047
commit 2d4bc1e613
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/sync.c
View File

@ -1875,8 +1875,10 @@ box_closed_p2( sync_vars_t *svars, int t )
Fclose( svars->jfp, 0 ); Fclose( svars->jfp, 0 );
if (!(DFlags & KEEPJOURNAL)) { if (!(DFlags & KEEPJOURNAL)) {
/* order is important! */ /* order is important! */
rename( svars->nname, svars->dname ); if (rename( svars->nname, svars->dname ))
unlink( svars->jname ); warn( "Warning: cannot commit sync state %s\n", svars->dname );
else if (unlink( svars->jname ))
warn( "Warning: cannot delete journal %s\n", svars->jname );
} }
sync_bail( svars ); sync_bail( svars );