From 2d4bc1e6138f81bcf160154017f19725cdc21051 Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Sat, 12 Apr 2014 18:31:18 +0200 Subject: [PATCH] error-check committing of sync state a failure here is rather unlikely, but let's be pedantic. a failure is not fatal (we'll just enter the journal replay path next time), so only print warnings. found by coverity. --- src/sync.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sync.c b/src/sync.c index e97efe8..ec7efa0 100644 --- a/src/sync.c +++ b/src/sync.c @@ -1875,8 +1875,10 @@ box_closed_p2( sync_vars_t *svars, int t ) Fclose( svars->jfp, 0 ); if (!(DFlags & KEEPJOURNAL)) { /* order is important! */ - rename( svars->nname, svars->dname ); - unlink( svars->jname ); + if (rename( svars->nname, svars->dname )) + warn( "Warning: cannot commit sync state %s\n", svars->dname ); + else if (unlink( svars->jname )) + warn( "Warning: cannot delete journal %s\n", svars->jname ); } sync_bail( svars );