lobo/isync
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
363 Commits 2 Branches 35 Tags 2 MiB
2c729bf9e6
Commit Graph

363 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Oswald Buddenhagen
2c729bf9e6 don't leak SSL objects 2011-03-27 11:54:45 +02:00
Oswald Buddenhagen
296ac0364c add CR after TUID during LF => CRLF conversion 2011-03-27 11:54:02 +02:00
Oswald Buddenhagen
8df1ebaf40 fix (another) out-of-bounds access in CRLF conversion 
if the header contained no CRs but the body (or the post-TUID part of
the header) did, the TUID insertion would add an excess CR, thus
overflowing the buffer by one byte.
 2011-03-27 11:54:02 +02:00
Oswald Buddenhagen
39006d7f24 document some breakage 2010-11-14 17:23:59 +01:00
Oswald Buddenhagen
d637772339 turns out, free(NULL) is just fine ... 2010-11-14 16:44:50 +01:00
Oswald Buddenhagen
e1fa867423 fix UIDNEXT handling 
UIDNEXT *can* be legally zero, so deal with it.

-REFMAIL: 4CA62BA1.4020104@lemma.co.uk
 2010-10-03 14:33:24 +02:00
Oswald Buddenhagen
5ade279839 don't hang after failed start_tls() 
we'd send a LOGOUT command in plain text while the server was already
expecting an encrypted command, which would typically lead to waiting
for more data and thus an indefinite hang.
so close the socket immediately instead of letting the normal shutdown
path take care of it.
inspired by a patch by Steven Flintham.

-REFMAIL: 4C9AB98E.3000400@lemma.co.uk
 2010-10-03 12:37:59 +02:00
Oswald Buddenhagen
70e87eb99e remove useless message 
don't complain about missing greeting response - we already complained
about an unexpected EOF anyway.
 2010-10-03 12:37:59 +02:00
Oswald Buddenhagen
90a38ea810 assert valid file handles 
i've seen error logs of the type
  SSL_write: Bad file descriptor
and i simply can't nail it, so go for some more drastic measures.
 2010-10-03 12:37:59 +02:00
Oswald Buddenhagen
72fd2aafb7 formatting 2010-10-03 12:37:59 +02:00
Oswald Buddenhagen
122e09fe60 beautify error messages 
don't print the error number - we print the error string anyway, so it
adds no value.
add some whitespace to the messages as well.
 2010-10-03 12:37:10 +02:00
Oswald Buddenhagen
db2bbbfef8 fix uninitialized variable read 
this is basically a security fix for nonsensical configurations:
if the specified CertificateFile did not contain any certificates,
we *might* have accepted an arbitrary server certificate.
 2010-04-05 13:06:58 +02:00
Oswald Buddenhagen
516c3bfa99 remove mail addresses from man pages 
apparently, some people don't see the "maintained by" bits, so make them
look harder for explicit contact information (to be found in AUTHORS).
 2010-02-28 22:23:20 +01:00
Oswald Buddenhagen
da39690aec fix compile with SSL on Mac OS X 
patch by Remko Tronçon <remko@el-tramo.be>
BUG: 2126899
 2010-02-07 22:31:11 +01:00
Oswald Buddenhagen
a8b4de463e add -P option to isync wrapper 
not really a backwards compat option, but whatever ...

based on a patch submitted long ago by "nobody".
BUG: 1433532
 2010-02-07 22:31:11 +01:00
Oswald Buddenhagen
5bc3bf5fbd fix rpm spec file 
-REFMAIL: 20090122213325.GA11572@crow.ths.tcoek12.org
 2010-02-07 22:31:11 +01:00
Oswald Buddenhagen
7728278b9c (new?) automake already sets docdir correctly for us 2010-02-07 22:31:11 +01:00
Oswald Buddenhagen
4729b1ee23 cvsignore => gitignore 2010-02-07 22:31:10 +01:00
Oswald Buddenhagen
474ce08b3a adjust ChangeLog generation to git 
now that log generation is cheap, don't store it in the SCM any more.
 2010-02-07 22:31:07 +01:00
Oswald Buddenhagen
2a5ff54683 fix "make distcheck" 
this makes the deb-clean target shadow build safe
 2010-02-07 12:25:21 +01:00
Oswald Buddenhagen
022d137b8c more to do 2010-02-06 11:58:36 +01:00
Oswald Buddenhagen
e6a356ffc7 add extra verbose mode which dumps the message contents 
i needed that to debug the line ending issues. maybe it will find other
uses as well ...
 2010-02-06 10:49:57 +01:00
Oswald Buddenhagen
d94dadbaeb fix line ending conversion logic 
imap may very well store messages with LF line endings. only RFC2822
requires CRLF.
consequently, preserve the line endings as much as possible unless the
mailbox format does not support it (this would be the case for unix mbox
- i actually have no idea about maildir).
 2010-02-06 10:49:57 +01:00
Oswald Buddenhagen
09dfddb36b some more error reporting relating malformed messages 2010-02-06 10:49:06 +01:00
Oswald Buddenhagen
ce45692ca5 refactoring. main part is killing struct imap_cmd_cb as such. 
issue_imap_cmd is split into new_imap_cmd and submit_imap_cmd, so the
command can be parametrized after it was instanciated.
 2008-08-31 20:14:59 +00:00
Oswald Buddenhagen
92914b37cc deal with UIDVALIDITY of 0 properly. 
-REF: 20080822094543.GA3528@ugly.local
 2008-08-23 07:54:00 +00:00
Oswald Buddenhagen
0d8bce1675 give the implicitly created imap account config the name of the store. 2008-04-13 09:56:44 +00:00
Oswald Buddenhagen
262999d092 make ssl certificate handling much more useful: 
- system-wide ca certs are auto-loaded
- private certs are accepted even if they are self-signed
 2008-04-13 09:51:27 +00:00
Oswald Buddenhagen
06521da30d - accept unset CertificateFile 
- print the certificate's fingerprint
- make the certificate acceptance prompt much less scary
 2008-04-12 08:58:50 +00:00
Oswald Buddenhagen
89519e343c ignore system flag extensions (\X-...) 2008-04-12 08:13:44 +00:00
Oswald Buddenhagen
f5f7dfb866 minor updates 2008-03-16 09:09:38 +00:00
Oswald Buddenhagen
474923bc6b compat wrapper: don't crash if neither host nor tunnel are specified. 
fixes:
CCMAIL: 449006@bugs.debian.org
 2008-02-23 14:18:21 +00:00
Oswald Buddenhagen
71fce2a622 quote user name in generated config. 
fixes:
CCMAIL: 456775@bugs.debian.org
 2008-02-23 09:37:38 +00:00
Oswald Buddenhagen
2f62a7f608 don't overlook 2nd and later single-letter options in last argument. 
reported by fedora
-REF: <1197916586.13945.120.camel@localhost.localdomain>
 2008-02-23 09:18:42 +00:00
Oswald Buddenhagen
a365e20660 put pointers to bdb open() into parentheses, so they won't be 
macro-expanded as libc open.
patch by fedora
-REF: <1197916586.13945.120.camel@localhost.localdomain>
 2008-02-23 09:01:51 +00:00
Oswald Buddenhagen
1f7b81fb8b reshuffle for "contact priority's" sake 2008-02-23 08:53:39 +00:00
Oswald Buddenhagen
2b37288e8d don't use #ifdef inside htons() arguments - it can be a macro. 
-REF: <lyy7ezyjah.fsf@gfn.org>
CCMAIL: Scott Gifford <sgifford@suspectclass.com>
 2007-09-22 08:45:41 +00:00
Oswald Buddenhagen
5b857b3b19 forward port (finally ...): add target for creating signed package 2007-04-04 17:03:45 +00:00
Oswald Buddenhagen
42ca262e39 #ifdef __linux__ for the crash handler. it compiles on other platforms, 
but the functionality is bound to linux' /proc structure.
 2007-04-04 16:19:47 +00:00
Oswald Buddenhagen
625f592fb7 fix crash due to uninited var when parsing IMAPServer. Thanks to 
CCMAIL: Antoine Reilles <tonio@NetBSD.org>
REF: <20070118182534.GA22288@arcelot.loria.fr>
 2007-02-10 15:37:46 +00:00
Oswald Buddenhagen
023d3ee577 fix error paths wrt sync drivers 2006-12-09 10:39:30 +00:00
Oswald Buddenhagen
9056504483 handle abnormal program exit during regtest 2006-12-09 10:38:11 +00:00
Oswald Buddenhagen
6800f1636e initialize mvars->t[1] to 1. helps enormously ... :} 2006-12-04 17:47:55 +00:00
Oswald Buddenhagen
e0d72cd5e3 reverse-map <Inbox> to INBOX when encountered during listing. 
usually this will be a no-op (when putting INBOX in Path, people
generally call it INBOX), but better safe than sorry.
 2006-11-18 13:17:13 +00:00
Oswald Buddenhagen
6985da5848 make compat wrapper default to current user for imap login 2006-11-09 17:57:38 +00:00
Oswald Buddenhagen
0e8a8d120d put INBOX in Maildir 2006-11-01 06:19:52 +00:00
Oswald Buddenhagen
2a9b0bd763 don't crash on truncating database. seems to affect only some bdb 
versions (e.g., 4.2).
 2006-10-24 17:37:57 +00:00
Oswald Buddenhagen
9b657a46a0 fix bug in newline conversion causing buffer overflows. 
this leads to segfaults and has some security impact.
 2006-08-10 07:01:02 +00:00
Oswald Buddenhagen
617d1a6e49 memmove for overlapping mem copies. 2006-08-10 06:33:18 +00:00
Oswald Buddenhagen
1b9f8b4c69 glibc seems to be *really* fucked up. 2006-07-31 05:30:46 +00:00