added BUGS section to manpage detailing the fact that we break the

maildir(5) spec by parsing the filename

change message delivery to use the method described in maildir(5)
This commit is contained in:
Michael Elkins 2000-12-21 18:16:44 +00:00
parent bbbe88e07d
commit b3d09b1723
2 changed files with 35 additions and 8 deletions

View File

@ -190,6 +190,14 @@ will then use the global value by default.
.B ~/.isyncrc .B ~/.isyncrc
Default configuration file Default configuration file
.. ..
.SH BUGS
maildir(5) states that readers should not attempt to parse the filename of a
a message other than the :info field. However, since
.B isync
relies on using the message UIDs that info must be inserted into the
filename in a way which will be interoperable with existing readers. So
the UID is placed in the filename of the messages in the local maildir
mailbox rather than the :info field.
.SH SEE ALSO .SH SEE ALSO
mutt(1), maildir(5) mutt(1), maildir(5)
.P .P

27
sync.c
View File

@ -25,6 +25,8 @@
#include <time.h> #include <time.h>
#include <fcntl.h> #include <fcntl.h>
#include <string.h> #include <string.h>
#include <sys/stat.h>
#include <errno.h>
#include "isync.h" #include "isync.h"
static unsigned int MaildirCount = 0; static unsigned int MaildirCount = 0;
@ -48,6 +50,7 @@ sync_mailbox (mailbox_t * mbox, imap_t * imap, int flags)
char *p; char *p;
int fd; int fd;
int ret; int ret;
struct stat sb;
for (cur = mbox->msgs; cur; cur = cur->next) for (cur = mbox->msgs; cur; cur = cur->next)
{ {
@ -104,11 +107,23 @@ sync_mailbox (mailbox_t * mbox, imap_t * imap, int flags)
continue; continue;
} }
for (;;)
{
/* create new file */ /* create new file */
snprintf (path, sizeof (path), "%s/tmp/%s.%ld_%d.%d.UID%d", snprintf (path, sizeof (path), "%s/tmp/%s.%ld_%d.%d.UID%d",
mbox->path, Hostname, time (0), MaildirCount++, mbox->path, Hostname, time (0), MaildirCount++,
getpid (), cur->uid); getpid (), cur->uid);
if (stat (path, &sb))
{
if (errno == ENOENT)
break;
}
sleep (2);
}
if (cur->flags) if (cur->flags)
{ {
/* append flags */ /* append flags */
@ -146,11 +161,15 @@ sync_mailbox (mailbox_t * mbox, imap_t * imap, int flags)
// printf ("moving %s to %s\n", path, newpath); // printf ("moving %s to %s\n", path, newpath);
if (rename (path, newpath)) /* its ok if this fails, the next time we sync the message
perror ("rename"); * will get pulled down
*/
if (link (path, newpath))
perror ("link");
} }
else
unlink(path); /* always remove the temp file */
unlink (path);
} }
} }
puts (""); puts ("");