make IMAP error messages less confusing

don't print the status, as the user doesn't really care whether it's
NO or BAD. more importantly, "NO LOGIN failed" is a rather misleading
thing to report.
This commit is contained in:
Oswald Buddenhagen 2022-05-05 11:33:08 +02:00
parent 3aead33008
commit 9b72e10320

View File

@ -1904,13 +1904,13 @@ imap_socket_read( void *aux )
resp = RESP_CANCEL; resp = RESP_CANCEL;
} }
} }
error( "IMAP command '%s' returned an error: %s %s\n", error( "IMAP command '%s' returned an error: %s\n",
starts_with( cmdp->cmd, -1, "LOGIN", 5 ) ? starts_with( cmdp->cmd, -1, "LOGIN", 5 ) ?
"LOGIN <user> <pass>" : "LOGIN <user> <pass>" :
starts_with( cmdp->cmd, -1, "AUTHENTICATE PLAIN", 18 ) ? starts_with( cmdp->cmd, -1, "AUTHENTICATE PLAIN", 18 ) ?
"AUTHENTICATE PLAIN <authdata>" : "AUTHENTICATE PLAIN <authdata>" :
cmdp->cmd, cmdp->cmd,
arg, cmd ? cmd : "" ); cmd ? cmd : "<unspecified>" );
} }
doresp: doresp:
if ((resp2 = parse_response_code( ctx, cmdp, cmd )) > resp) if ((resp2 = parse_response_code( ctx, cmdp, cmd )) > resp)