lobo/isync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

moan about trashing in non-UIDPLUS boxes

Browse source 
... as that's inherently racy, as the manual says.
This commit is contained in:
Oswald Buddenhagen 2022-04-21 16:14:27 +02:00
parent edbf9a35da
commit 6fe7172901
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/driver.h
View file

@ -107,7 +107,8 @@ BIT_ENUM(
#define STORE(store) \ #define STORE(store) \
store *next; \ store *next; \
driver_t *driver; \ driver_t *driver; \
store##_conf *conf; /* foreign */ store##_conf *conf; /* foreign */ \
uchar racy_trash;
typedef struct store { typedef struct store {
STORE(struct store) STORE(struct store)

12
src/sync.c
View file

@ -813,8 +813,16 @@ box_opened2( sync_vars_t *svars, int t )
else if (chan->ops[N] & (OP_OLD | OP_NEW | OP_UPGRADE)) else if (chan->ops[N] & (OP_OLD | OP_NEW | OP_UPGRADE))
opts[F] |= OPEN_FLAGS; opts[F] |= OPEN_FLAGS;
} }
svars->opts[F] = svars->drv[F]->prepare_load_box( ctx[F], opts[F] ); for (t = 0; t < 2; t++) {
svars->opts[N] = svars->drv[N]->prepare_load_box( ctx[N], opts[N] ); svars->opts[t] = svars->drv[t]->prepare_load_box( ctx[t], opts[t] );
if (opts[t] & ~svars->opts[t] & OPEN_UID_EXPUNGE) {
if (!ctx[t]->racy_trash) {
ctx[t]->racy_trash = 1;
notice( "Notice: Trashing in Store %s is prone to race conditions.\n",
svars->chan->stores[t]->name );
}
}
}
ARRAY_INIT( &mexcs ); ARRAY_INIT( &mexcs );
if ((svars->opts[F] & OPEN_PAIRED) && !(svars->opts[F] & OPEN_OLD) && chan->max_messages) { if ((svars->opts[F] & OPEN_PAIRED) && !(svars->opts[F] & OPEN_OLD) && chan->max_messages) {