lobo/isync
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

handle mixing simple and compound sync options more explicitly

Browse Source
This commit is contained in:
Oswald Buddenhagen 2022-01-13 14:05:45 +01:00
parent e70a20477c
commit 44ad8f0361
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/config.c
View File

@ -324,18 +324,30 @@ merge_ops( int cops, int ops[], const char *chan_name )
return 1; return 1;
} }
// Mix in non-overlapping Push/Pull or New, etc. // Mix in non-overlapping Push/Pull or New, etc.
// Do the ops first, so e.g. PullNew Push Flags will error out.
ops[F] |= cops & OP_MASK_TYPE;
ops[N] |= cops & OP_MASK_TYPE;
if (cops & XOP_PULL) { if (cops & XOP_PULL) {
if (cops & (XOP_PUSH | OP_MASK_TYPE)) {
// Mixing instant effect flags with row/column flags would be confusing,
// so instead everything is instant effect. This implies that mixing
// direction with type would cause overlaps, so PullNew Push Delete, etc.
// is invalid.
// Pull Push covers everything, so makes no sense to combine.
ivl:
error( "Invalid combination of simple and compound Sync options %s.\n",
channel_str( chan_name ) );
return 1;
}
if (ops[N] & OP_MASK_TYPE) if (ops[N] & OP_MASK_TYPE)
goto ovl; goto ovl;
ops[N] |= OP_MASK_TYPE; ops[N] |= OP_MASK_TYPE;
} } else if (cops & XOP_PUSH) {
if (cops & XOP_PUSH) { if (cops & OP_MASK_TYPE)
goto ivl;
if (ops[F] & OP_MASK_TYPE) if (ops[F] & OP_MASK_TYPE)
goto ovl; goto ovl;
ops[F] |= OP_MASK_TYPE; ops[F] |= OP_MASK_TYPE;
} else {
ops[F] |= cops & OP_MASK_TYPE;
ops[N] |= cops & OP_MASK_TYPE;
} }
} else if (cops & (OP_MASK_TYPE | XOP_MASK_DIR)) { // Pull New, etc. } else if (cops & (OP_MASK_TYPE | XOP_MASK_DIR)) { // Pull New, etc.
if (ops[F] & XOP_TYPE_NOOP) if (ops[F] & XOP_TYPE_NOOP)