lobo/isync
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve socket connect() error reporting with poll()

Browse Source 
turns out that poll() may (and on linux does) signal POLLERR on
connection failure. this is unlike select(), which is specified to
signal write readiness in every case.
consequently, check whether we are connecting before checking for
POLLERR.
This commit is contained in:
Oswald Buddenhagen 2013-03-29 18:11:57 +01:00
parent d1900941f4
commit 37a28d8133
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/socket.c
View File

@ -633,14 +633,14 @@ socket_fd_cb( int events, void *aux )
{ {
conn_t *conn = (conn_t *)aux; conn_t *conn = (conn_t *)aux;
if (events & POLLERR) { if (conn->state == SCK_CONNECTING) {
error( "Unidentified socket error from %s.\n", conn->name ); socket_connected( conn );
socket_fail( conn );
return; return;
} }
if (conn->state == SCK_CONNECTING) { if (events & POLLERR) {
socket_connected( conn ); error( "Unidentified socket error from %s.\n", conn->name );
socket_fail( conn );
return; return;
} }