lobo/isync
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

call fdatasync() after updating .uidvalidity files

Browse Source 
they must be flushed before the file system meta data, as otherwise we
may end up with duplicate UIDs after a system crash.
This commit is contained in:
Oswald Buddenhagen 2012-09-09 12:18:14 +02:00
parent 47fe4b7998
commit 2e07e68630
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/drv_maildir.c
View File

@ -42,6 +42,10 @@
# define LEGACY_FLOCK 1 # define LEGACY_FLOCK 1
#endif #endif
#ifndef _POSIX_SYNCHRONIZED_IO
# define fdatasync fsync
#endif
#ifdef USE_DB #ifdef USE_DB
#include <db.h> #include <db.h>
#endif /* USE_DB */ #endif /* USE_DB */
@ -428,7 +432,7 @@ maildir_store_uid( maildir_store_t *ctx )
n = sprintf( buf, "%d\n%d\n", ctx->gen.uidvalidity, ctx->nuid ); n = sprintf( buf, "%d\n%d\n", ctx->gen.uidvalidity, ctx->nuid );
lseek( ctx->uvfd, 0, SEEK_SET ); lseek( ctx->uvfd, 0, SEEK_SET );
if (write( ctx->uvfd, buf, n ) != n || ftruncate( ctx->uvfd, n )) { if (write( ctx->uvfd, buf, n ) != n || ftruncate( ctx->uvfd, n ) || fdatasync( ctx->uvfd )) {
error( "Maildir error: cannot write UIDVALIDITY.\n" ); error( "Maildir error: cannot write UIDVALIDITY.\n" );
return DRV_BOX_BAD; return DRV_BOX_BAD;
} }