remove redundant validations

src/commands/analysis.zig

@@ -27,10 +27,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len > 0) {
         try cli.stderrPrint(ctx.io, "Error: 'analysis' takes no arguments\n");

src/commands/audit.zig

@@ -2280,10 +2280,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(_: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     var parsed: ParsedArgs = .{};
     var i: usize = 0;

src/commands/cache.zig

@@ -35,10 +35,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 /// Data types to show in the stats table (skip candles_meta and meta — internal bookkeeping).
 const display_types = [_]DataType{
     .candles_daily,

src/commands/compare.zig

@@ -128,10 +128,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     const io = ctx.io;
     const today = ctx.today;

src/commands/contributions.zig

@@ -228,10 +228,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     const io = ctx.io;
     const today = ctx.today;

src/commands/divs.zig

@@ -27,10 +27,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'divs' requires a symbol argument\n");

src/commands/earnings.zig

@@ -33,10 +33,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'earnings' requires a symbol argument\n");

src/commands/enrich.zig

@@ -43,10 +43,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'enrich' requires a portfolio file path or symbol\n");

src/commands/etf.zig

@@ -28,10 +28,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'etf' requires a symbol argument\n");

src/commands/framework.zig

@@ -24,18 +24,20 @@
 //! ```
 //!
 //! The `validateCommandModule(Module)` walker enforces the contract at
-//! comptime with copy-paste-ready error messages.
+//! comptime with copy-paste-ready error messages. It's invoked from a
+//! single registry walk in `src/main.zig`; individual command files
+//! do NOT carry their own validation block. See the doc-comment on
+//! `validateCommandModule` for the rationale.
 //!
 //! ## Global-option promotion criterion
 //!
 //! A flag belongs as a global iff it is *orthogonal* to every command's
 //! semantics (purely an I/O / output / cache-policy concern) AND every
-//! command would honor it identically. Today's globals are
+//! command would honor it identically. Today's globals are `--no-color`,
-//! `--no-color`, `-p`, `-w` (and `--refresh` / `--no-refresh` once
+//! `-p`, `-w`, and `--refresh-data=<auto|never|force>`. `--as-of` does
-//! commit 18c lands). `--as-of` does NOT pass this test because its
+//! NOT pass this test because its meaning varies between view-as-of
-//! meaning varies between view-as-of (`projections`) and write-as-of
+//! (`projections`) and write-as-of (`snapshot`), and the two-sided
-//! (`snapshot`), and the two-sided commands need two endpoints, not
+//! commands need two endpoints, not one — so it stays per-command.
-//! one — so it stays per-command.
 
 const std = @import("std");
 const zfin = @import("../root.zig");
@@ -264,8 +266,20 @@ fn resolveUserPath(
 
 /// Validate a command module against the framework contract. Emits
 /// a `@compileError` with the full expected signature for any
-/// missing or wrong-shape decl. Call from the `command_modules`
+/// missing or wrong-shape decl.
-/// registry walker in `src/main.zig`.
+///
+/// **Call site policy: registry-walk only.** This function should
+/// be invoked exactly once per command, from the `command_modules`
+/// registry walker in `src/main.zig`. Do NOT add in-file
+/// `comptime { framework.validateCommandModule(@This()); }` blocks
+/// to individual command files — they're redundant with the
+/// registry walk under both `zig build` and ZLS build-on-save (the
+/// only ZLS mode that evaluates comptime; ZLS's own semantic
+/// analyzer doesn't run comptime reliably). The registry walk also
+/// produces a better diagnostic, identifying the offending command
+/// by its registry name (`commands.cache`) rather than just its
+/// module identity. The TUI tab framework follows the same policy
+/// in `src/tui.zig`.
 pub fn validateCommandModule(comptime Module: type) void {
     comptime {
         const mod_name = @typeName(Module);

src/commands/history.zig

@@ -85,10 +85,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub const Error = error{
     UnexpectedArg,
     InvalidFlagValue,

src/commands/lookup.zig

@@ -31,10 +31,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'lookup' requires a CUSIP argument\n");

src/commands/milestones.zig

@@ -64,10 +64,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub const RunError = error{
     UnexpectedArg,
     MissingStep,

src/commands/options.zig

@@ -35,10 +35,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'options' requires a symbol argument\n");

src/commands/perf.zig

@@ -35,10 +35,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'perf' requires a symbol argument\n");

src/commands/portfolio.zig

@@ -32,10 +32,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len > 0) {
         const a = cmd_args[0];

src/commands/projections.zig

@@ -110,10 +110,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     const io = ctx.io;
     const today = ctx.today;

src/commands/quote.zig

@@ -32,10 +32,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 /// Quote data extracted from the real-time API (or synthesized from candles).
 pub const QuoteData = struct {
     price: f64,

src/commands/snapshot.zig

@@ -98,10 +98,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     var parsed: ParsedArgs = .{};
     var i: usize = 0;

src/commands/splits.zig

@@ -27,10 +27,6 @@ pub const meta: framework.Meta = .{
     ,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     if (cmd_args.len < 1) {
         try cli.stderrPrint(ctx.io, "Error: 'splits' requires a symbol argument\n");

src/commands/version.zig

@@ -35,10 +35,6 @@ pub const meta: framework.Meta = .{
     .uppercase_first_arg = false,
 };
 
-comptime {
-    framework.validateCommandModule(@This());
-}
-
 /// Parse `--verbose`/`-v`. Unknown args produce an error on stderr.
 pub fn parseArgs(ctx: *framework.RunCtx, cmd_args: []const []const u8) !ParsedArgs {
     var parsed: ParsedArgs = .{};

src/tui/tab_framework.zig

@@ -216,13 +216,13 @@ pub fn alwaysEnabled() fn (*App) bool {
 // Every error message includes the full expected signature so the
 // developer knows exactly what to add, copy-paste ready.
 //
-// Call sites: the registry in `src/tui.zig` calls this once per
+// Call site policy: registry-walk only. The registry in
-// entry. Each `<name>_tab.zig` can also opt in via a comptime
+// `src/tui.zig` calls this once per entry. Do NOT add in-file
-// block in the file itself for faster local feedback:
+// `comptime { framework.validateTabModule(@This()); }` blocks to
-//
+// individual tab files — they're redundant with the registry walk
-// ```zig
+// under both `zig build` and ZLS build-on-save (the only ZLS mode
-// comptime { framework.validateTabModule(@This()); }
+// that runs comptime), and the registry walk produces a better
-// ```
+// diagnostic. Mirrors the policy in `src/commands/framework.zig`.
 
 /// Validate a tab module against the framework contract. Emits a
 /// `@compileError` with the full expected signature for any