lobo/aws-sdk-for-zig
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

remove completed TODOs from test
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
Emil Lerch 2022-01-19 19:14:24 -08:00
parent 3e9fab6ca5
commit acba4d7962
Signed by: lobo
GPG Key ID: A7B62D657EF764F8
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/aws_signing.zig
View File

@ -694,7 +694,6 @@ test "canonical query" {
const path = "blahblahblah?foo=bar&zed=dead&qux&equals=x=y&Action=ListUsers&Version=2010-05-08"; const path = "blahblahblah?foo=bar&zed=dead&qux&equals=x=y&Action=ListUsers&Version=2010-05-08";
// { // {
// // TODO: Remove block
// std.testing.log_level = .debug; // std.testing.log_level = .debug;
// _ = try std.io.getStdErr().write("\n"); // _ = try std.io.getStdErr().write("\n");
// } // }
@ -803,16 +802,13 @@ test "can sign" {
.content_type = "application/json", .content_type = "application/json",
.headers = headers.items, .headers = headers.items,
}; };
{ // {
// TODO: Remove block // std.testing.log_level = .debug;
std.testing.log_level = .debug; // _ = try std.io.getStdErr().write("\n");
_ = try std.io.getStdErr().write("\n"); // }
}
// we could look at sigv4 signing tests at: // we could look at sigv4 signing tests at:
// https://github.com/awslabs/aws-c-auth/blob/ace1311f8ef6ea890b26dd376031bed2721648eb/tests/sigv4_signing_tests.c#L1478 // https://github.com/awslabs/aws-c-auth/blob/ace1311f8ef6ea890b26dd376031bed2721648eb/tests/sigv4_signing_tests.c#L1478
//
// for valid signatures. TODO: Get literally anything working first
const config = Config{ const config = Config{
.region = "us-east-1", .region = "us-east-1",
.service = "service", .service = "service",
@ -824,7 +820,6 @@ test "can sign" {
.signing_time = 1440938160, // 20150830T123600Z .signing_time = 1440938160, // 20150830T123600Z
}; };
// TODO: There is an x-amz-content-sha256. Investigate // TODO: There is an x-amz-content-sha256. Investigate
//
var signed_req = try signRequest(allocator, req, config); var signed_req = try signRequest(allocator, req, config);
defer freeSignedRequest(allocator, &signed_req, config); defer freeSignedRequest(allocator, &signed_req, config);