lobo/aws-sdk-for-zig
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

update snake case to handle space followed by single character at end of string

Browse Source
This commit is contained in:
Emil Lerch 2024-02-29 13:43:48 -08:00
parent d06c8da3bb
commit 2c9a80e363
Signed by: lobo
GPG Key ID: A7B62D657EF764F8
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
codegen/src/snake.zig
View File

@ -28,10 +28,22 @@ pub fn fromPascalCase(allocator: std.mem.Allocator, name: []const u8) ![]u8 {
// prev_codepoint/ascii_prev_char (and target_inx) // prev_codepoint/ascii_prev_char (and target_inx)
target_inx = setNext(lowercase(curr_char), rc, target_inx); target_inx = setNext(lowercase(curr_char), rc, target_inx);
target_inx = setNext('_', rc, target_inx); target_inx = setNext('_', rc, target_inx);
curr_char = (try isAscii(utf8_name.nextCodepoint())).?; var maybe_curr_char = (try isAscii(utf8_name.nextCodepoint()));
if (maybe_curr_char == null) {
std.log.err("Error on fromPascalCase processing name '{s}'", .{name});
}
curr_char = maybe_curr_char.?;
maybe_curr_char = (try isAscii(utf8_name.nextCodepoint()));
if (maybe_curr_char == null) {
// We have reached the end of the string (e.g. "Resource Explorer 2")
// We need to do this check before we setNext, so that we don't
// end up duplicating the last character
break;
// std.log.err("Error on fromPascalCase processing name '{s}', curr_char = '{}'", .{ name, curr_char });
}
target_inx = setNext(lowercase(curr_char), rc, target_inx); target_inx = setNext(lowercase(curr_char), rc, target_inx);
prev_char = curr_char; prev_char = curr_char;
curr_char = (try isAscii(utf8_name.nextCodepoint())).?; curr_char = maybe_curr_char.?;
continue; continue;
} }
if (between(curr_char, 'A', 'Z')) { if (between(curr_char, 'A', 'Z')) {
@ -60,6 +72,7 @@ pub fn fromPascalCase(allocator: std.mem.Allocator, name: []const u8) ![]u8 {
target_inx = setNext(lowercase(curr_char), rc, target_inx); target_inx = setNext(lowercase(curr_char), rc, target_inx);
rc[target_inx] = 0; rc[target_inx] = 0;
_ = allocator.resize(rc, target_inx);
return rc[0..target_inx]; return rc[0..target_inx];
} }
@ -134,3 +147,11 @@ test "IoT 1Click Devices Service" {
// turn into. Should it be iot_1click_... or iot_1_click...? // turn into. Should it be iot_1click_... or iot_1_click...?
try expectEqualStrings("iot_1_click_devices_service", snake_case); try expectEqualStrings("iot_1_click_devices_service", snake_case);
} }
test "Resource Explorer 2" {
const allocator = std.testing.allocator;
const snake_case = try fromPascalCase(allocator, "Resource Explorer 2");
defer allocator.free(snake_case);
// NOTE: There is some debate amoung humans about what this should
// turn into. Should it be iot_1click_... or iot_1_click...?
try expectEqualStrings("resource_explorer_2", snake_case);
}