From 411846b5846d3ac9e92e32c60cbfa7537fe3918c Mon Sep 17 00:00:00 2001
From: Emil Lerch <emil@lerch.org>
Date: Thu, 3 Sep 2026 13:47:20 -0700
Subject: [PATCH] document lifetime of error messages

---
 src/srf.zig | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/srf.zig b/src/srf.zig
index 3ce148a..438d457 100644
--- a/src/srf.zig
+++ b/src/srf.zig
@@ -29,6 +29,12 @@ pub const ParseLineError = struct {
 };
 pub const Diagnostics = struct {
     ptr: *anyopaque,
+
+    /// adds an error to the diagnostics implementation. Note that this carries
+    /// no allocator and the ParseLineError message field may be stack allocated.
+    /// It is up to the implementation to manage diagnostics message lifetime
+    /// BoundedDiagnostics struct keeps an internal 256 byte/message buffer
+    /// for diagnostics messages
     addErrorFn: *const fn (*anyopaque, ParseLineError) ParseError!void,
     has_errors: bool = false,
 
@@ -37,6 +43,9 @@ pub const Diagnostics = struct {
         self.has_errors = true;
     }
 };
+
+/// Implements the Diagnostics interface, maintaining a 256 byte/message
+/// stack allocated buffer for error messages
 pub fn BoundedDiagnostics(comptime max_errors: usize) type {
     return struct {
         buffer: [max_errors]ParseLineError,